-
-
Notifications
You must be signed in to change notification settings - Fork 190
BUGFIX: #3442 ignore deprecations during binary check #3462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 9.0
Are you sure you want to change the base?
BUGFIX: #3442 ignore deprecations during binary check #3462
Conversation
|
Slightly related, as it eases finding such issues: #3441 |
kitsunet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not convinced we should do that, there could be other output apart from deprecations that should block using the binary, also like if there are deprecations maybe use a log level that silences them if you want to use that php version?
|
This issue just popped up in slack when there is an error like I think we should reconsider if the check really has to be done at (production) runtime or if this should be part of the (one time) neos setup ( So i think we should try to remove the (expensive) php validation here from the |
|
But in the setup this doesn't help at all. Mostly I run into this during changing the PHP versions in already productive running systems and you forgot to change the binary path in the config. |
|
Hmmm, I think it is problematic to remove this check if we cannot hint to the user that something is wrong. In fact we would need to point the user to the setup in error cases; otherwise they will not find it... I need to think it through more carefully though. |
With #3441 the cause should be clearly visible. And then you can just fix it, no? |
fixes: #3442
seems kinda hacky i dont know how else we can easily make the output parseable.
I guess we could turn of deprecations and all error handling for that request but i dindt want to start the fun to make these parameters work cross platform (windows) so here is an easy fix.
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions